Commit 62d5ece7 authored by Adrian Schmutzler's avatar Adrian Schmutzler
Browse files

ramips: remove bogus ralink,mtd-eeprom with offset 0x4

Several devices in mt76x8 subtarget use the following line to set
up wmac in their DTS(I) files:

ralink,mtd-eeprom = <&factory 0x4>

This is strange for several reasons:
- They should use mediatek,mtd-eeprom on this SOC
- The caldata is supposed to start at 0x0
- The parent DTSI mt7628an.dtsi specifies mediatek,mtd-eeprom anyway,
  starting from 0x0
- The offset coincides with the default location of the MAC address
  in caldata

Based on the comment in b28e94d4

 ("ramips: MiWiFi Nano fixes"),
it looks like the author for this device wanted to actually use
mtd-mac-address instead of ralink,mtd-eeprom. A check on the same
device revealed that actually the MAC address start at offset 4 there,
so the correct caldata offset is 0x0.

Based on these findings, and the fact that the expected location on
this SOC is 0x0, we remove the "ralink,mtd-eeprom = <&factory 0x4>"
statement from all devices in ramips (being only mt7628an anyway).

Thanks to Sungbo Eo for finding and researching this.
Reported-by: default avatarSungbo Eo <mans0n@gorani.run>
Fixes: b28e94d4

 ("ramips: MiWiFi Nano fixes")
Signed-off-by: default avatarAdrian Schmutzler <freifunk@adrianschmutzler.de>
(cherry picked from commit 09d38a3b)
parent 94153971
......@@ -65,7 +65,6 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
&ethernet {
......
......@@ -100,5 +100,4 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
......@@ -108,7 +108,6 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
&ethernet {
......
......@@ -20,7 +20,6 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
&ethernet {
......
......@@ -135,7 +135,6 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
&ethernet {
......
......@@ -111,7 +111,6 @@
&wmac {
status = "okay";
ralink,mtd-eeprom = <&factory 0x4>;
};
&ethernet {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment